static_call: Allow module use without exposing static_call_key
authorJosh Poimboeuf <jpoimboe@redhat.com>
Wed, 27 Jan 2021 23:18:37 +0000 (17:18 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Mar 2021 12:31:53 +0000 (14:31 +0200)
commita63068e93917927d443e32609dde9298bcd14833
treea67bc7552e261fb2447b0e2f5ad69bafd033e0fc
parent433cd7ca386c832a6e165d76f376c29dcac14fbb
static_call: Allow module use without exposing static_call_key

[ Upstream commit 73f44fe19d359635a607e8e8daa0da4001c1cfc2 ]

When exporting static_call_key; with EXPORT_STATIC_CALL*(), the module
can use static_call_update() to change the function called.  This is
not desirable in general.

Not exporting static_call_key however also disallows usage of
static_call(), since objtool needs the key to construct the
static_call_site.

Solve this by allowing objtool to create the static_call_site using
the trampoline address when it builds a module and cannot find the
static_call_key symbol. The module loader will then try and map the
trampole back to a key before it constructs the normal sites list.

Doing this requires a trampoline -> key associsation, so add another
magic section that keeps those.

Originally-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/20210127231837.ifddpn7rhwdaepiu@treble
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/include/asm/static_call.h
include/asm-generic/vmlinux.lds.h
include/linux/static_call.h
include/linux/static_call_types.h
kernel/static_call.c
tools/include/linux/static_call_types.h
tools/objtool/check.c