firmware: arm_scmi: Check if platform has released shmem before using
authorSudeep Holla <sudeep.holla@arm.com>
Mon, 8 Jul 2019 14:48:36 +0000 (15:48 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 12 Aug 2019 11:22:59 +0000 (12:22 +0100)
commit9dc34d635c67e57051853855c43249408641a5ab
treeed835ee597152d61b9cdfa92ab044910cf257df6
parent5b65af8f60f580188c0be55b25cd45908024b985
firmware: arm_scmi: Check if platform has released shmem before using

Sometimes platfom may take too long to respond to the command and OS
might timeout before platform transfer the ownership of the shared
memory region to the OS with the response.

Since the mailbox channel associated with the channel is freed and new
commands are dispatch on the same channel, OS needs to wait until it
gets back the ownership. If not, either OS may end up overwriting the
platform response for the last command(which is fine as OS timed out
that command) or platform might overwrite the payload for the next
command with the response for the old.

The latter is problematic as platform may end up interpretting the
response as the payload. In order to avoid such race, let's wait until
the OS gets back the ownership before we prepare the shared memory with
the payload for the next command.

Reported-by: Jim Quinlan <james.quinlan@broadcom.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/driver.c