iwlegacy: Check the return value of pcie_capability_read_*()
authorBolarinwa Olayemi Saheed <refactormyself@gmail.com>
Mon, 13 Jul 2020 17:55:27 +0000 (19:55 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 15 Jul 2020 16:47:32 +0000 (19:47 +0300)
commit9018fd7f2a73e9b290f48a56b421558fa31e8b75
treedf4389713689b2368019a96d4d284dc3ac5fc8a3
parent0db5bc7b344736731a3982885402914b34dd252b
iwlegacy: Check the return value of pcie_capability_read_*()

On failure pcie_capability_read_dword() sets it's last parameter, val
to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
failure. This would introduce a bug because (x & x) == (~0 & x).

This bug can be avoided without changing the function's behaviour if the
return value of pcie_capability_read_dword is checked to confirm success.

Check the return value of pcie_capability_read_dword() to ensure success.

Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200713175529.29715-3-refactormyself@gmail.com
drivers/net/wireless/intel/iwlegacy/common.c