media: dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER
authorMalcolm Priestley <tvboxspy@gmail.com>
Mon, 26 Nov 2018 20:18:25 +0000 (15:18 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jan 2019 16:38:40 +0000 (17:38 +0100)
commit80562cf3b1886d59f8a966807b4029e143198dc6
tree24ed7884c516bedbb787239193bd730a6e8e6cfa
parentf295bc9b8c9c7c0a9a49fa39538277422679a5cf
media: dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER

commit 255095fa7f62ff09b6f61393414535c59c6b4cb0 upstream.

commit 1a0c10ed7bb1 ("media: dvb-usb-v2: stop using coherent memory for
URBs") incorrectly adds URB_FREE_BUFFER after every urb transfer.

It cannot use this flag because it reconfigures the URBs accordingly
to suit connected devices. In doing a call to usb_free_urb is made and
invertedly frees the buffers.

The stream buffer should remain constant while driver is up.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
CC: stable@vger.kernel.org # v4.18+
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/usb/dvb-usb-v2/usb_urb.c