KVM: VMX: Don't use vcpu->run->internal.ndata as an array index
authorReiji Watanabe <reijiw@google.com>
Tue, 13 Apr 2021 15:47:40 +0000 (15:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Apr 2021 11:00:59 +0000 (13:00 +0200)
commit7f64753835a78c7d2cc2932a5808ef3b7fd4c050
tree006204b3d910fdb299d4c5afc37e894e0a12d09f
parentc670ff84fac9c92c4260b359f24fff1312b98218
KVM: VMX: Don't use vcpu->run->internal.ndata as an array index

[ Upstream commit 04c4f2ee3f68c9a4bf1653d15f1a9a435ae33f7a ]

__vmx_handle_exit() uses vcpu->run->internal.ndata as an index for
an array access.  Since vcpu->run is (can be) mapped to a user address
space with a writer permission, the 'ndata' could be updated by the
user process at anytime (the user process can set it to outside the
bounds of the array).
So, it is not safe that __vmx_handle_exit() uses the 'ndata' that way.

Fixes: 1aa561b1a4c0 ("kvm: x86: Add "last CPU" to some KVM_EXIT information")
Signed-off-by: Reiji Watanabe <reijiw@google.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
Message-Id: <20210413154739.490299-1-reijiw@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/kvm/vmx/vmx.c