drivers/gpu/drm/ast: Fix infinite loop if read fails
authorRussell Currey <ruscur@russell.cc>
Thu, 15 Dec 2016 05:12:41 +0000 (16:12 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Jan 2017 07:32:20 +0000 (08:32 +0100)
commit66469319c01a1a36c78d0a8535e3dcbc1349bb19
tree9f9ec30f027bf2648c551b59b1968915be3f83be
parent8dbd6f709e62394fedb4fe75a3e553cbb6cbdbd3
drivers/gpu/drm/ast: Fix infinite loop if read fails

commit 298360af3dab45659810fdc51aba0c9f4097e4f6 upstream.

ast_get_dram_info() configures a window in order to access BMC memory.
A BMC register can be configured to disallow this, and if so, causes
an infinite loop in the ast driver which renders the system unusable.

Fix this by erroring out if an error is detected.  On powerpc systems with
EEH, this leads to the device being fenced and the system continuing to
operate.

Signed-off-by: Russell Currey <ruscur@russell.cc>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20161215051241.20815-1-ruscur@russell.cc
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/ast/ast_main.c