net: tipc: Fix a sleep-in-atomic bug in tipc_msg_reverse
authorJia-Ju Bai <baijiaju1990@163.com>
Sat, 10 Jun 2017 09:03:35 +0000 (17:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jul 2017 12:40:14 +0000 (14:40 +0200)
commit57360bc3c7a6fc9c7422e422508bf77166a05028
tree9e0be237abd91b1339e7a53d603474e1a776c265
parentbb566ce3a60eded40ae4a3421a59c0f5f1c7ef20
net: tipc: Fix a sleep-in-atomic bug in tipc_msg_reverse

[ Upstream commit 343eba69c6968190d8654b857aea952fed9a6749 ]

The kernel may sleep under a rcu read lock in tipc_msg_reverse, and the
function call path is:
tipc_l2_rcv_msg (acquire the lock by rcu_read_lock)
  tipc_rcv
    tipc_sk_rcv
      tipc_msg_reverse
        pskb_expand_head(GFP_KERNEL) --> may sleep
tipc_node_broadcast
  tipc_node_xmit_skb
    tipc_node_xmit
      tipc_sk_rcv
        tipc_msg_reverse
          pskb_expand_head(GFP_KERNEL) --> may sleep

To fix it, "GFP_KERNEL" is replaced with "GFP_ATOMIC".

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/tipc/msg.c