pinctrl: imx: fix unsigned check if nfuncs with less than or equal zero
authorDong Aisheng <aisheng.dong@nxp.com>
Fri, 27 Apr 2018 19:01:48 +0000 (03:01 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 2 May 2018 12:36:31 +0000 (14:36 +0200)
commit562088ee27917a4c5e86cca31cfaf1fbf63899a3
tree4b90b0623d39d2dee4fa8a3198f4f63b9ad1a462
parentfdab33d5d286d45636c80149ae5440c26965c440
pinctrl: imx: fix unsigned check if nfuncs with less than or equal zero

The unsigned integer nfuncs is being error checked with a value less
or equal to zero; this is always false if of_get_child_count returns a
-ve for an error condition since nfuncs is not signed. Fix this by
making variables nfuncs and i signed integers.

Detected with Coccinelle:
drivers/pinctrl/freescale/pinctrl-imx.c:620:6-12: WARNING: Unsigned
expression compared with zero: nfuncs <= 0

Cc: Linus Walleij <linus.walleij@linaro.org>
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/freescale/pinctrl-imx.c