nvme: Discard workaround for non-conformant devices
authorEduard Hasenleithner <eduard@hasenleithner.at>
Tue, 12 Nov 2019 20:55:01 +0000 (21:55 +0100)
committerKeith Busch <kbusch@kernel.org>
Tue, 12 Nov 2019 21:37:38 +0000 (06:37 +0900)
commit530436c45ef2e446c12538a400e465929a0b3ade
tree370f6d4b250bd2bd9f5cd26e27aa2b6e497ae017
parent400b6a7b13a3fd71cff087139ce45dd1e5fff444
nvme: Discard workaround for non-conformant devices

Users observe IOMMU related errors when performing discard on nvme from
non-compliant nvme devices reading beyond the end of the DMA mapped
ranges to discard.

Two different variants of this behavior have been observed: SM22XX
controllers round up the read size to a multiple of 512 bytes, and Phison
E12 unconditionally reads the maximum discard size allowed by the spec
(256 segments or 4kB).

Make nvme_setup_discard unconditionally allocate the maximum DSM buffer
so the driver DMA maps a memory range that will always succeed.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=202665
Signed-off-by: Eduard Hasenleithner <eduard@hasenleithner.at>
[changelog, use existing define, kernel coding style]
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/core.c