net/rds: Fix a use after free in rds_message_map_pages
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Wed, 31 Mar 2021 01:59:59 +0000 (18:59 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Apr 2021 06:42:09 +0000 (08:42 +0200)
commit4cfae7b23889fd7e6af2e371c3d2f5eb7e49de0b
tree49f004661604e777140214f619c384281ca69f76
parent05bbe9d85a4c2cbf79aea1023fa8ee8330bfe547
net/rds: Fix a use after free in rds_message_map_pages

[ Upstream commit bdc2ab5c61a5c07388f4820ff21e787b4dfd1ced ]

In rds_message_map_pages, the rm is freed by rds_message_put(rm).
But rm is still used by rm->data.op_sg in return value.

My patch assigns ERR_CAST(rm->data.op_sg) to err before the rm is
freed to avoid the uaf.

Fixes: 7dba92037baf3 ("net/rds: Use ERR_PTR for rds_message_alloc_sgs()")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Reviewed-by: HÃ¥kon Bugge <haakon.bugge@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/rds/message.c