can: tcan4x5x: tcan4x5x_init(): fix initialization - clear MRAM before entering Norma...
authorTorin Cooper-Bennun <torin@maxiluxsystems.com>
Fri, 26 Feb 2021 16:34:41 +0000 (16:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Mar 2021 16:06:11 +0000 (17:06 +0100)
commit473bce9b9393a3a990ed7c9708af38df553f2712
tree2ec2634d138190a5aae8a81505fa669934e13b70
parentc537011c99abc9d1e1e9bc2a3bb32fda1cda4583
can: tcan4x5x: tcan4x5x_init(): fix initialization - clear MRAM before entering Normal Mode

commit 2712625200ed69c642b9abc3a403830c4643364c upstream.

This patch prevents a potentially destructive race condition. The
device is fully operational on the bus after entering Normal Mode, so
zeroing the MRAM after entering this mode may lead to loss of
information, e.g. new received messages.

This patch fixes the problem by first initializing the MRAM, then
bringing the device into Normale Mode.

Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Link: https://lore.kernel.org/r/20210226163440.313628-1-torin@maxiluxsystems.com
Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/m_can/tcan4x5x.c