xfrm: Fix stack-out-of-bounds read on socket policy lookup.
authorSteffen Klassert <steffen.klassert@secunet.com>
Wed, 29 Nov 2017 05:53:55 +0000 (06:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Feb 2018 10:05:40 +0000 (11:05 +0100)
commit46b317167d01130c5cc98ad042b2955c58f14597
tree86a3d981b0c8ee7209ab99804785a89dc5357456
parent274ee93f0b12ce1865579ea2bbb783642c72c31f
xfrm: Fix stack-out-of-bounds read on socket policy lookup.

commit ddc47e4404b58f03e98345398fb12d38fe291512 upstream.

When we do tunnel or beet mode, we pass saddr and daddr from the
template to xfrm_state_find(), this is ok. On transport mode,
we pass the addresses from the flowi, assuming that the IP
addresses (and address family) don't change during transformation.
This assumption is wrong in the IPv4 mapped IPv6 case, packet
is IPv4 and template is IPv6.

Fix this by catching address family missmatches of the policy
and the flow already before we do the lookup.

Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/xfrm/xfrm_policy.c