tcp: tcp_fragment() should apply sane memory limits
authorEric Dumazet <edumazet@google.com>
Sat, 18 May 2019 12:12:05 +0000 (05:12 -0700)
committerJason Liu <jason.hui.liu@nxp.com>
Fri, 6 Sep 2019 03:11:35 +0000 (11:11 +0800)
commit4520222214ff157f81b7eba5f710a9b6819ceab9
tree3753fec3331ccc712a74f6e70bd356cfc197a84e
parentfe0210ffc4467bc037194527433f720097b272fa
tcp: tcp_fragment() should apply sane memory limits

commit f070ef2ac66716357066b683fb0baf55f8191a2e upstream.

Jonathan Looney reported that a malicious peer can force a sender
to fragment its retransmit queue into tiny skbs, inflating memory
usage and/or overflow 32bit counters.

TCP allows an application to queue up to sk_sndbuf bytes,
so we need to give some allowance for non malicious splitting
of retransmit queue.

A new SNMP counter is added to monitor how many times TCP
did not allow to split an skb if the allowance was exceeded.

Note that this counter might increase in the case applications
use SO_SNDBUF socket option to lower sk_sndbuf.

CVE-2019-11478 : tcp_fragment, prevent fragmenting a packet when the
socket is already using more than half the allowed space

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Jonathan Looney <jtl@netflix.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Acked-by: Yuchung Cheng <ycheng@google.com>
Reviewed-by: Tyler Hicks <tyhicks@canonical.com>
Cc: Bruce Curtis <brucec@netflix.com>
Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit ec83921899a571ad70d582934ee9e3e07f478848)
include/uapi/linux/snmp.h
net/ipv4/proc.c
net/ipv4/tcp_output.c