HID: corsair: fix control-transfer error handling
authorJohan Hovold <johan@kernel.org>
Thu, 12 Jan 2017 17:17:43 +0000 (18:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Jan 2017 07:24:38 +0000 (08:24 +0100)
commit35028599bc8884f33e36a9353be6f1401940aa29
treec98906030e6f14e08ecf25aa156cdf45d80f15d4
parent63df1ccb937f67fbefa0a77415b3a4d10434a09b
HID: corsair: fix control-transfer error handling

commit 7a546af50eb78ab99840903083231eb635c8a566 upstream.

Make sure to check for short control transfers in order to avoid parsing
uninitialised buffer data and leaking it to user space.

Note that the backlight and macro-mode buffer constraints are kept as
loose as possible in order to avoid any regressions should the current
buffer sizes be larger than necessary.

Fixes: 6f78193ee9ea ("HID: corsair: Add Corsair Vengeance K90 driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-corsair.c