projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 86c1fe8) | patch
bnx2x: Remove read_status_t function casts
authorKees Cook <keescook@chromium.org>
Fri, 15 Nov 2019 05:07:12 +0000 (21:07 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 16 Nov 2019 20:50:57 +0000 (12:50 -0800)
commit2c855d73f2f6107f5b8ebc45f8b934bf7f4419e0
tree89c0f3214308c9bc3379b560cf3b6cc847d9b1eatree
parent86c1fe8857afb379522fd8dabce9d348672c31c1commit | diff
bnx2x: Remove read_status_t function casts

The function casts for .read_status callbacks end up casting some int
return values to u8. This seems to be bug-prone (-EINVAL being returned
into something that appears to be true/false), but fixing the function
prototypes doesn't change the existing behavior. Fix the return values
to remove the casts.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c diff | blob | history