firmware_loader: make firmware_fallback_sysfs() print more useful
authorLuis R. Rodriguez <mcgrof@kernel.org>
Thu, 10 May 2018 20:08:44 +0000 (13:08 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 May 2018 14:43:10 +0000 (16:43 +0200)
commit27d5d7dc9aafd6db3d7aeb49cdbfe578fc1b8663
treed2d8eb38d5528decf4301a7c97f125198deb6829
parent06bfd3c8ab1dbf0031022d056a90ace682f6a94c
firmware_loader: make firmware_fallback_sysfs() print more useful

If we resort to using the sysfs fallback mechanism we don't print
the filename. This can be deceiving given we could have a series of
callers intertwined and it'd be unclear exactly for what firmware
this was meant for.

Additionally, although we don't currently use FW_OPT_NO_WARN when
dealing with the fallback mechanism, we will soon, so just respect
its use consistently.

And even if you *don't* want to print always on failure, you may
want to print when debugging so enable dynamic debug print when
FW_OPT_NO_WARN is used.

Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/fallback.c