thunderbolt: Fix a leak in tb_retimer_add()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 29 Mar 2021 06:07:18 +0000 (09:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Apr 2021 06:42:03 +0000 (08:42 +0200)
commit256ece954961411c9dc77a08566cda47fabc8d71
treee6f08ac6b1ab9a3a93fb2774801820e2f7086023
parentb830650c1a0c665a48a24b7cf4bf46f7e5b10119
thunderbolt: Fix a leak in tb_retimer_add()

commit bec4d7c93afc07dd0454ae41c559513f858cfb83 upstream.

After the device_register() succeeds, then the correct way to clean up
is to call device_unregister().  The unregister calls both device_del()
and device_put().  Since this code was only device_del() it results in
a memory leak.

Fixes: dacb12877d92 ("thunderbolt: Add support for on-board retimers")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thunderbolt/retimer.c