ALSA: usb-audio: Fix potential out-of-bound access at parsing SU
authorTakashi Iwai <tiwai@suse.de>
Tue, 21 Nov 2017 16:00:32 +0000 (17:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2017 08:39:05 +0000 (08:39 +0000)
commit23353220b53f7b1cd700842d54d01784c58a5438
tree557e03bfc418e3d66fdb7639f3fa70e314bdb9b1
parent85cc020b46b5728e6cd4557b493ff27e4482774f
ALSA: usb-audio: Fix potential out-of-bound access at parsing SU

commit f658f17b5e0e339935dca23e77e0f3cad591926b upstream.

The usb-audio driver may trigger an out-of-bound access at parsing a
malformed selector unit, as it checks the header length only after
evaluating bNrInPins field, which can be already above the given
length.  Fix it by adding the length check beforehand.

Fixes: 99fc86450c43 ("ALSA: usb-mixer: parse descriptors with structs")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/mixer.c