clocksource/drivers/bcm2835_timer: Fix memory leak of timer
authorColin Ian King <colin.king@canonical.com>
Thu, 19 Dec 2019 21:32:46 +0000 (21:32 +0000)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 16 Jan 2020 18:06:57 +0000 (19:06 +0100)
commit2052d032c06761330bca4944bb7858b00960e868
tree56b99bc958b2155a94313cb4c4a5fa15c4edf4a8
parentf5ac896b6a23eb46681cdbef440c1d991b04e519
clocksource/drivers/bcm2835_timer: Fix memory leak of timer

Currently when setup_irq fails the error exit path will leak the
recently allocated timer structure.  Originally the code would
throw a panic but a later commit changed the behaviour to return
via the err_iounmap path and hence we now have a memory leak. Fix
this by adding a err_timer_free error path that kfree's timer.

Addresses-Coverity: ("Resource Leak")
Fixes: 524a7f08983d ("clocksource/drivers/bcm2835_timer: Convert init function to return error")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20191219213246.34437-1-colin.king@canonical.com
drivers/clocksource/bcm2835_timer.c