afs: Fix cell removal
authorDavid Howells <dhowells@redhat.com>
Fri, 16 Oct 2020 12:21:14 +0000 (13:21 +0100)
committerDavid Howells <dhowells@redhat.com>
Fri, 16 Oct 2020 13:38:26 +0000 (14:38 +0100)
commit1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6
tree2cf39ef5abecf6afc46d2ba5db3a6b8ffdb24a54
parent286377f6bdf71568a4cf07104fe44006ae0dba6d
afs: Fix cell removal

Fix cell removal by inserting a more final state than AFS_CELL_FAILED that
indicates that the cell has been unpublished in case the manager is already
requeued and will go through again.  The new AFS_CELL_REMOVED state will
just immediately leave the manager function.

Going through a second time in the AFS_CELL_FAILED state will cause it to
try to remove the cell again, potentially leading to the proc list being
removed.

Fixes: 989782dcdc91 ("afs: Overhaul cell database management")
Reported-by: syzbot+b994ecf2b023f14832c1@syzkaller.appspotmail.com
Reported-by: syzbot+0e0db88e1eb44a91ae8d@syzkaller.appspotmail.com
Reported-by: syzbot+2d0585e5efcd43d113c2@syzkaller.appspotmail.com
Reported-by: syzbot+1ecc2f9d3387f1d79d42@syzkaller.appspotmail.com
Reported-by: syzbot+18d51774588492bf3f69@syzkaller.appspotmail.com
Reported-by: syzbot+a5e4946b04d6ca8fa5f3@syzkaller.appspotmail.com
Suggested-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Hillf Danton <hdanton@sina.com>
fs/afs/cell.c
fs/afs/internal.h