pinctrl: mcp23s08: use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 4 Jan 2019 17:37:33 +0000 (11:37 -0600)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 11 Jan 2019 12:23:18 +0000 (13:23 +0100)
commit16f4372fd7a5a560abe0edb4c68be1200599dc8a
treec15fec2f674a411ec9779eeb854ab981202f7b25
parent6e737a4e921ea99125955d0d8821d8da129b03bd
pinctrl: mcp23s08: use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-mcp23s08.c