nvme-fc: correct hang in nvme_ns_remove()
authorJames Smart <jsmart2021@gmail.com>
Thu, 11 Jan 2018 23:21:38 +0000 (15:21 -0800)
committerChristoph Hellwig <hch@lst.de>
Wed, 17 Jan 2018 16:55:02 +0000 (17:55 +0100)
commit0fd997d3f77296522e836f7002e8a0636c9886aa
tree3b7880700121db30b5f889afc75795560cb2f74f
parentd625d05ef0f0914a706d824fab85472a42be6659
nvme-fc: correct hang in nvme_ns_remove()

When connectivity is lost to a device, the association is terminated
and the blk-mq queues are quiesced/stopped. When connectivity is
re-established, they are resumed.

If connectivity is lost for a sufficient amount of time that the
controller is then deleted, the delete path starts tearing down queues,
and eventually calling nvme_ns_remove(). It appears that pending
commands may cause blk_cleanup_queue() to never complete and the
teardown stalls.

Correct by starting the ns queues after transitioning to a DELETING
state, allowing pending commands to be flushed with io failures. Thus
the delete path is clear when reached.

Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/fc.c